Add user agent to globaluserinfo call#1542
Merged
Merged
Conversation
DHardy-WMF
approved these changes
Jul 10, 2026
DHardy-WMF
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for including fallbacks with those env vars as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set a compliant User-Agent header on globaluserinfo API requests
The _get_user_info_request helper in TWLight/users/helpers/editor_data.py issued requests via urllib.request.urlopen() without setting a User-Agent header, so requests went out with Python's default Python-urllib/x.y agent. Wikimedia blocks this generic agent per its User Agent policy, returning HTTP 403 Forbidden.
Add a descriptive
TWLIGHT_USER_AGENTconstant containing the application name, URL, and contact address (sourced fromTWLIGHT_ERROR_MAILTO), and send it via urllib.request.Request on the globaluserinfo query.Phabricator Ticket
How Has This Been Tested?
{'id': 69468694, 'name': 'TheresNoTime-WMF', 'editcount': 709}) instead of 403 Forbidden, and the full OAuth login / editor-creation path completes without the 500.Types of changes
What types of changes does your code introduce? Add an
xin all the boxes that apply: